.net 10 upgrade #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.NET 10 upgrade. Also updated some test dependencies and readme style.
All tests confirmed to work on my machine.
Please double check if the
GetItemAsyncmethod change insrc/RazorLight/Razor/FileSystemRazorProject.csmakes sense, the related test failed on me during the upgrade. It seemed to be that adding the null check like insrc\RazorLight\Razor\EmbeddedRazorProject.csmakes sense. For this, i also changed theNull_TemplateKey_ThrowsOn_GetItemtest to actually passnull.PS, I actually just wanted to make an issue regarding .NET 10 but since you locked the issues tab you tricked me into creating this PR :). So, if you would be so kind to enable the issues tab, that would improve the community.